This repository was archived by the owner on May 5, 2021. It is now read-only.
Add the capacity to extend a RedLock lock, as per the specification #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdstmporter
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some small changes top the base class that allow:
(1) use of an extend method to extend a lock that is already owner by a specified ttl
(2) test if a lock with a given name is already taken
The extension mechanism is based on the specification in the original paper, and uses an in-DB Lua script to ensure atomicity.
I have also updated the CLI accordingly.
This is a small change, but adds a useful capability, enabling lock owners to poll and extend at regular intervals. I hope you think it adds to the library as is.